Reduce bad requests count

atomex-protocol · Aug 23, 2022 · e0cdee9 · e0cdee9
1 parent f6dbaa9
commit e0cdee9
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 3 deletions.
diff --git a/src/exchange/ratesProvider/atomex/atomexRatesProvider.ts b/src/exchange/ratesProvider/atomex/atomexRatesProvider.ts
@@ -12,9 +12,9 @@ export class AtomexRatesProvider implements RatesProvider {
 
   async getPrice(baseCurrency: Currency['id'], quoteCurrency: Currency['id']): Promise<BigNumber | undefined> {
     const symbol = `${baseCurrency}/${quoteCurrency}`;
-    const quote = (await this.exchangeService.getTopOfBook([symbol]))?.[0];
+    const quote = (await this.exchangeService.getTopOfBook([{ from: baseCurrency, to: quoteCurrency }]))?.[0];
 
-    return quote ? this.getMiddlePrice(quote) : undefined;
+    return quote && quote.symbol == symbol ? this.getMiddlePrice(quote) : undefined;
   }
 
   private getMiddlePrice(quote: Quote): BigNumber {

diff --git a/src/exchange/ratesProvider/binance/binanceRatesProvider.ts b/src/exchange/ratesProvider/binance/binanceRatesProvider.ts
@@ -8,15 +8,22 @@ import { isErrorDto } from './utils';
 
 export class BinanceRatesProvider implements RatesProvider {
   private static readonly baseUrl = 'https://www.binance.com';
+  private static readonly priceUrlPath = '/api/v3/ticker/price';
 
   private readonly httpClient: HttpClient;
+  private _allSymbols: Set<string> | undefined;
 
   constructor() {
     this.httpClient = new HttpClient(BinanceRatesProvider.baseUrl);
   }
 
   async getPrice(baseCurrency: Currency['id'], quoteCurrency: Currency['id']): Promise<BigNumber | undefined> {
-    const urlPath = `/api/v3/ticker/price?symbol=${baseCurrency}${quoteCurrency}`;
+    const symbol = `${baseCurrency}${quoteCurrency}`;
+    const allSymbols = await this.getAllSymbols();
+    if (!allSymbols.has(symbol))
+      return undefined;
+
+    const urlPath = `${BinanceRatesProvider.priceUrlPath}?symbol=${symbol}`;
     const responseDto = await this.httpClient.request<BinanceRatesDto | BinanceErrorDto>({ urlPath }, false);
 
     return this.mapRatesDtoToPrice(responseDto);
@@ -28,4 +35,18 @@ export class BinanceRatesProvider implements RatesProvider {
 
     return new BigNumber(dto.price);
   }
+
+  private async getAllSymbols(): Promise<Set<string>> {
+    if (!this._allSymbols)
+      this._allSymbols = new Set(await this.requestAllSymbols());
+
+    return this._allSymbols;
+  }
+
+  private async requestAllSymbols(): Promise<string[]> {
+    const urlPath = BinanceRatesProvider.priceUrlPath;
+    const responseDto = await this.httpClient.request<BinanceRatesDto[]>({ urlPath }, false);
+
+    return responseDto.map(dto => dto.symbol);
+  }
 }