Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circulating_supply ValueError, and fix custom color payload #218

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

shadowv0vshadow
Copy link
Collaborator

  1. circulating_supply must use atomcal-value, not utxo value,
  2. fix custom color payload: payload must be safely convert to int, it can't be float. If it cannot be correctly converted to an integer, it will be assigned a value of 0.

@shadowv0vshadow shadowv0vshadow changed the base branch from master to develop June 24, 2024 09:48
@wizz-wallet-dev
Copy link
Collaborator

fix custom color payload: payload must be safely convert to int, it can't be float. If it cannot be correctly converted to an integer, it will be assigned a value of 0.

@shadowv0vshadow Does it involves reindex?

Copy link
Collaborator

@wizz-wallet-dev wizz-wallet-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM per above comment

@shadowv0vshadow shadowv0vshadow merged commit aeab930 into develop Jun 24, 2024
4 checks passed
@wizz-wallet-dev wizz-wallet-dev deleted the fix-bug branch June 25, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants