Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL encoding bug: "Incorrect signature" when creating resources with special characters in URL #874

Open
joepio opened this issue Apr 15, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@joepio
Copy link
Member

joepio commented Apr 15, 2024

  • Create a drive with a non-URL allowed special character (e.g. an emoji) in the name
  • Refresh the page
  • "incorrect signature error"
  • Using websockets (retry) works

Thoughts

  • AtomicServer does not have appropriate URL checking at this point. This could be the explanation for why websockets works, but HTTP doesn't.

Cause

  • Not clear. Perhaps something in

Fix

Only allow a small subset of chars in subjects

  • Don't allow complex URL encoding stuff that is error prone
  • Server throws an error if any illegal character is present in subject.
  • Makes some existing, valid URLs not compatible.

Resource.setSubject throws error if invalid

@joepio joepio added the bug Something isn't working label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants