General fixes to the setup

[kamijean]

No description provided.

[coveralls]

Coverage remained the same at 99.851% when pulling 1c3d05e on general_fixes into b3c2620 on master.

[bfcoder]

I'm not sure this change is good. I think this should remain a string in the seeds. The forked apps use strings to list the tenants too. There really isn't any reason to put them in the secrets. Since you can't change it without changing for everyone.

[kamijean]

In the apartment.rb it's selecting the tenant names by the lti keys -- config.tenant_names = lambda { ApplicationInstance.pluck(:lti_key) }

So the tenant name and the lti_key ought to be the same, so I was just changing it to be the same as whatever the lti_key was being set to. The admin one above are both strings in setting the lti_key and tenant. I can change it to a string of what the default_lti_key is. It just seemed easier to have it reference the same place so if one changes they both change.

[bfcoder]

ok, I guess that is a good change. I just don't think it needs to be in the secrets. IMO

[bfcoder]

But maybe in this instance where it is just an example, it should be in the secrets..

[bfcoder]

Let's keep it this way.

[jbasdf]

Unfortunately this is tricky because of how we develop our applications. Locally we use atomicjolt.xyz and every subdomain has to be setup by our bootstrap script which gets the subdomains from the .env file (it can't read ruby code). For the sake of a quick example we seed a basic LTI application which is called lti-example. We have to get the bootstrap script to generate an nginx config and get the seeds to add a db entry with the matching domain. The only single point to store that data is in the .env. We could skip the secrets and put ENV['something'] in the seeds. Would that make it simpler?

[bfcoder]

I'd rather the secrets than env. If we want env, we should load the env in the secrets and still use the secrets here.

[bfcoder]

Looks good.

[coveralls]

Coverage remained the same at 99.855% when pulling 67f0732 on general_fixes into 66d83b7 on master.

[jbasdf]

Unfortunately this is tricky because of how we develop our applications. Locally we use atomicjolt.xyz and every subdomain has to be setup by our bootstrap script which gets the subdomains from the .env file (it can't read ruby code). For the sake of a quick example we seed a basic LTI application which is called lti-example. We have to get the bootstrap script to generate an nginx config and get the seeds to add a db entry with the matching domain. The only single point to store that data is in the .env. We could skip the secrets and put ENV['something'] in the seeds. Would that make it simpler?