A little more linting #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 14, 2016
| export default function(actions, requests){ | ||
|
|
||
| var types = _.reduce(actions, (result, key) => { | ||
| export default function(actions, requests) { |
There was a problem hiding this comment.
Missing space before function parentheses space-before-function-paren
bfcoder
added a commit
that referenced
this pull request
Feb 8, 2017
* Update rubocop * Refactor verify_oauth_response error message generation
bfcoder
added a commit
that referenced
this pull request
Feb 8, 2017
* Removes ngrok, foreman and guard. * Remove unused seeds * Clean up readme * Removes dependency on s3-website.json * Removes unused npm commands * Fix rubocop offenses (#2) * Update rubocop, remove erroneous cops, ignore specific files * Fix rubocop offenses * Change DeprecatedHashMethods to PreferredHashMethods * Add ruby version * Remove .jshintrc as it is not used. * re-align route * add routes to exclude block length * remove ngrok and guardfile * remove old code * Removes unused package * Update yarn lock * Fix lint violations * Refactor verify_oauth_response error message generation (#3) * Update rubocop * Refactor verify_oauth_response error message generation * Remove extra assignment * Remove s3-website from packages * more lint updates ignore unused var as that file is deleted in the admin branch * Add .env.example code back * Update readme * Remove canvas rake task update readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.