Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix form to correctly set lti_type radio buttons. #30

Merged
merged 1 commit into from
Feb 15, 2017
Merged

Conversation

bfcoder
Copy link
Collaborator

@bfcoder bfcoder commented Feb 15, 2017

Previously they were not getting assigned the same name. Thus you could select all 3 types. The next problem was the value wasn't getting set to anything. This fixes both issues.

lti_type

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.855% when pulling 94c76f1 on bf-fix-lti-type into 350f6de on master.

Copy link
Contributor

@jbasdf jbasdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbasdf jbasdf merged commit f0de65f into master Feb 15, 2017
@jbasdf jbasdf deleted the bf-fix-lti-type branch February 15, 2017 15:31
jbasdf pushed a commit that referenced this pull request Oct 27, 2017
* Moving core functionality out into a npm pkg

* trying things out

* change versions

* fix useage of packages

* adds script to view package contents

* remove code from here

* remove blank line
bfcoder pushed a commit that referenced this pull request Nov 2, 2017
upgrade the fuel package to 1.0.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants