adds error condition to canvas middleware #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfcoder
reviewed
Feb 28, 2017
client/js/libs/canvas/middleware.js
Outdated
| }); // Dispatch the new data | ||
| }).catch((error) => { | ||
| store.dispatch({ | ||
| type : action.canvas.type + DONE, |
There was a problem hiding this comment.
Even Justin says not to do this. Align it if you must, but don't use the colon to align it. Align with spaces only please.
bfcoder
approved these changes
Feb 28, 2017
jbasdf
pushed a commit
that referenced
this pull request
Mar 27, 2018
* upgrade to react 16 and react router 4 * remove our eslint package * fixes specs
jbasdf
added a commit
that referenced
this pull request
Mar 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes bug causing promise to not resolve and not dispatch to reducer is there was an error during the canvas request.