Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass domain to attempt unique email address #50

Merged
merged 1 commit into from
Mar 7, 2017
Merged

Conversation

bfcoder
Copy link
Collaborator

@bfcoder bfcoder commented Mar 6, 2017

This fixes a situation where an lti user is attempted to be created with the same email as an existing user in the database. domain is now passed in to the generate unique email address method.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.88% when pulling 6d9ac2d on bf-fix-email-domain into 70b16da on master.

Copy link
Contributor

@jbasdf jbasdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbasdf jbasdf merged commit a52ba3f into master Mar 7, 2017
@jbasdf jbasdf deleted the bf-fix-email-domain branch March 7, 2017 00:47
jbasdf added a commit that referenced this pull request Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants