Add configs to application and application_instance #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bfcoder
commented
Mar 9, 2017
•
bfcoder
commented
- Add configs to application and application_instance in the database
- Add serializer for configs
- Can now access model.foo instead of model.config[:foo]
- Ensure new app instance copies the default config from an app if it is blank
- Add example to seeds
- Add UI to edit default config for applications
- Add UI to edit config for app instance
- Add/update specs
Can now access model.foo instead of model.config[:foo] Ensure new app instance copies the default config from an app if it is blank Add example to seeds
jbasdf
reviewed
Mar 9, 2017
| @@ -22,12 +22,14 @@ def show | |||
| def create | |||
| @application_instance.domain = | |||
| "#{@application_instance.lti_key}.#{ENV['APP_URL']}" | |||
| @application_instance.config = params[:application_instance][:config] | |||
There was a problem hiding this comment.
Add a note about why we have to use the param directly instead of using strong params.
jbasdf
reviewed
Mar 9, 2017
app/models/application_instance.rb
Outdated
| @@ -12,11 +13,15 @@ class ApplicationInstance < ActiveRecord::Base | |||
| errors.add(:lti_key, "cannot be changed after creation") if lti_key_changed? | |||
| end | |||
|
|
|||
| # example store_accessor for config | |||
| store_accessor :config, :foo | |||
There was a problem hiding this comment.
Comment this out and add more instruction on what it's for.
Show warning for bad JSON in config Fix variables in textarea component Explicitly use each prop in Textarea component use camelCase for defaultConfig
houndci-bot
reviewed
Mar 9, 2017
| @@ -8,6 +8,7 @@ export default class Modal extends React.Component { | |||
| application: React.PropTypes.shape({ | |||
| name: React.PropTypes.string, | |||
| description: React.PropTypes.string, | |||
| default_config: React.PropTypes.string, | |||
There was a problem hiding this comment.
'application.default_config' PropType is defined but prop is never used react/no-unused-prop-types
| @@ -11,6 +11,7 @@ export default class Modal extends React.Component { | |||
| save: React.PropTypes.func.isRequired, | |||
| applicationInstance: React.PropTypes.shape({ | |||
| id: React.PropTypes.number, | |||
| config: React.PropTypes.string, | |||
There was a problem hiding this comment.
'applicationInstance.config' PropType is defined but prop is never used react/no-unused-prop-types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.