Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a modal that displays the lti xml config for that instance. #53

Merged
merged 5 commits into from
Apr 12, 2017

Conversation

bfcoder
Copy link
Collaborator

@bfcoder bfcoder commented Apr 7, 2017

name: React.PropTypes.string,
}),
applicationInstance: React.PropTypes.shape({
id: React.PropTypes.number,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'applicationInstance.id' PropType is defined but prop is never used react/no-unused-prop-types

closeModal: React.PropTypes.func.isRequired,
application: React.PropTypes.shape({
id: React.PropTypes.number,
name: React.PropTypes.string,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'application.name' PropType is defined but prop is never used react/no-unused-prop-types

isOpen: React.PropTypes.bool.isRequired,
closeModal: React.PropTypes.func.isRequired,
application: React.PropTypes.shape({
id: React.PropTypes.number,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'application.id' PropType is defined but prop is never used react/no-unused-prop-types

@bfcoder bfcoder requested a review from jbasdf April 7, 2017 22:21
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 99.884% when pulling a5cdff3 on bf-display-xml-config into a1cdd40 on master.

Copy link
Contributor

@jbasdf jbasdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 99.885% when pulling 63ebdf5 on bf-display-xml-config into 9450345 on master.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f9db4b8 on bf-display-xml-config into ** on master**.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 99.885% when pulling f9db4b8 on bf-display-xml-config into 47c6cbe on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 99.885% when pulling 0444238 on bf-display-xml-config into fbde4ab on master.

@jbasdf jbasdf merged commit 31f4ec1 into master Apr 12, 2017
@jbasdf jbasdf deleted the bf-display-xml-config branch April 12, 2017 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants