-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a modal that displays the lti xml config for that instance. #53
Conversation
name: React.PropTypes.string, | ||
}), | ||
applicationInstance: React.PropTypes.shape({ | ||
id: React.PropTypes.number, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'applicationInstance.id' PropType is defined but prop is never used react/no-unused-prop-types
closeModal: React.PropTypes.func.isRequired, | ||
application: React.PropTypes.shape({ | ||
id: React.PropTypes.number, | ||
name: React.PropTypes.string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'application.name' PropType is defined but prop is never used react/no-unused-prop-types
isOpen: React.PropTypes.bool.isRequired, | ||
closeModal: React.PropTypes.func.isRequired, | ||
application: React.PropTypes.shape({ | ||
id: React.PropTypes.number, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'application.id' PropType is defined but prop is never used react/no-unused-prop-types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes Unknown when pulling f9db4b8 on bf-display-xml-config into ** on master**. |
https://www.pivotaltracker.com/story/show/141273517