Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add course links to course install #54

Merged
merged 2 commits into from
Apr 12, 2017
Merged

Add course links to course install #54

merged 2 commits into from
Apr 12, 2017

Conversation

bfcoder
Copy link
Collaborator

@bfcoder bfcoder commented Apr 10, 2017

Link goes to course in a new tab. If the tool is installed to the course, it takes you to the external tool page. https://www.pivotaltracker.com/story/show/141273415

course_link

@bfcoder bfcoder requested a review from jbasdf April 10, 2017 16:57
name: React.PropTypes.string,
lti_key: React.PropTypes.string,
lti_secret: React.PropTypes.string,
lti_config_xml: React.PropTypes.string,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'applicationInstance.lti_config_xml' PropType is defined but prop is never used react/no-unused-prop-types

applicationInstance: React.PropTypes.shape({
name: React.PropTypes.string,
lti_key: React.PropTypes.string,
lti_secret: React.PropTypes.string,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'applicationInstance.lti_secret' PropType is defined but prop is never used react/no-unused-prop-types

installedTool: React.PropTypes.shape({}),
applicationInstance: React.PropTypes.shape({
name: React.PropTypes.string,
lti_key: React.PropTypes.string,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'applicationInstance.lti_key' PropType is defined but prop is never used react/no-unused-prop-types

courseId: React.PropTypes.number.isRequired,
installedTool: React.PropTypes.shape({}),
applicationInstance: React.PropTypes.shape({
name: React.PropTypes.string,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'applicationInstance.name' PropType is defined but prop is never used react/no-unused-prop-types

name: React.PropTypes.string,
lti_key: React.PropTypes.string,
lti_secret: React.PropTypes.string,
lti_config_xml: React.PropTypes.string,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'applicationInstance.lti_config_xml' PropType is defined but prop is never used react/no-unused-prop-types

applicationInstance: React.PropTypes.shape({
name: React.PropTypes.string,
lti_key: React.PropTypes.string,
lti_secret: React.PropTypes.string,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'applicationInstance.lti_secret' PropType is defined but prop is never used react/no-unused-prop-types

installedTool: React.PropTypes.shape({}),
applicationInstance: React.PropTypes.shape({
name: React.PropTypes.string,
lti_key: React.PropTypes.string,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'applicationInstance.lti_key' PropType is defined but prop is never used react/no-unused-prop-types

courseId: React.PropTypes.number.isRequired,
installedTool: React.PropTypes.shape({}),
applicationInstance: React.PropTypes.shape({
name: React.PropTypes.string,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'applicationInstance.name' PropType is defined but prop is never used react/no-unused-prop-types

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.884% when pulling 29e9fce on bf-add-course-links into a1cdd40 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.885% when pulling 43e5035 on bf-add-course-links into 9450345 on master.

Copy link
Contributor

@jbasdf jbasdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@jbasdf jbasdf merged commit b92dfd6 into master Apr 12, 2017
@jbasdf jbasdf deleted the bf-add-course-links branch April 12, 2017 15:52
bfcoder pushed a commit that referenced this pull request Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants