-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add course links to course install #54
Conversation
name: React.PropTypes.string, | ||
lti_key: React.PropTypes.string, | ||
lti_secret: React.PropTypes.string, | ||
lti_config_xml: React.PropTypes.string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'applicationInstance.lti_config_xml' PropType is defined but prop is never used react/no-unused-prop-types
applicationInstance: React.PropTypes.shape({ | ||
name: React.PropTypes.string, | ||
lti_key: React.PropTypes.string, | ||
lti_secret: React.PropTypes.string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'applicationInstance.lti_secret' PropType is defined but prop is never used react/no-unused-prop-types
installedTool: React.PropTypes.shape({}), | ||
applicationInstance: React.PropTypes.shape({ | ||
name: React.PropTypes.string, | ||
lti_key: React.PropTypes.string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'applicationInstance.lti_key' PropType is defined but prop is never used react/no-unused-prop-types
courseId: React.PropTypes.number.isRequired, | ||
installedTool: React.PropTypes.shape({}), | ||
applicationInstance: React.PropTypes.shape({ | ||
name: React.PropTypes.string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'applicationInstance.name' PropType is defined but prop is never used react/no-unused-prop-types
name: React.PropTypes.string, | ||
lti_key: React.PropTypes.string, | ||
lti_secret: React.PropTypes.string, | ||
lti_config_xml: React.PropTypes.string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'applicationInstance.lti_config_xml' PropType is defined but prop is never used react/no-unused-prop-types
applicationInstance: React.PropTypes.shape({ | ||
name: React.PropTypes.string, | ||
lti_key: React.PropTypes.string, | ||
lti_secret: React.PropTypes.string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'applicationInstance.lti_secret' PropType is defined but prop is never used react/no-unused-prop-types
installedTool: React.PropTypes.shape({}), | ||
applicationInstance: React.PropTypes.shape({ | ||
name: React.PropTypes.string, | ||
lti_key: React.PropTypes.string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'applicationInstance.lti_key' PropType is defined but prop is never used react/no-unused-prop-types
courseId: React.PropTypes.number.isRequired, | ||
installedTool: React.PropTypes.shape({}), | ||
applicationInstance: React.PropTypes.shape({ | ||
name: React.PropTypes.string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'applicationInstance.name' PropType is defined but prop is never used react/no-unused-prop-types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
Link goes to course in a new tab. If the tool is installed to the course, it takes you to the external tool page. https://www.pivotaltracker.com/story/show/141273415