Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move lib into apps directory #65

Merged
merged 1 commit into from
Apr 27, 2017
Merged

Move lib into apps directory #65

merged 1 commit into from
Apr 27, 2017

Conversation

jbasdf
Copy link
Contributor

@jbasdf jbasdf commented Apr 27, 2017

Rails 5 doesn't allow autoloading the libs directory due to threading constraints. We can set the libs dir to eager load, but the recommended approach is to move library code into the apps directory where it will always be loaded and automatically reloaded in development. This also allows us to leave tasks in the root libs directory.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.622% when pulling 8e2b241 on movers into 20ca900 on master.

Copy link
Collaborator

@bfcoder bfcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jbasdf jbasdf merged commit 84f6292 into master Apr 27, 2017
@jbasdf jbasdf deleted the movers branch April 27, 2017 15:30
jbasdf added a commit that referenced this pull request Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants