copy stuffs to clipboard #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenHSmith13
reviewed
Feb 23, 2017
| @@ -1,5 +1,6 @@ | |||
| import React from 'react'; | |||
| import _ from 'lodash'; | |||
| import CopyToClipboard from 'react-copy-to-clipboard'; | |||
BenHSmith13
reviewed
Feb 23, 2017
| color: $purple; | ||
| } | ||
| } | ||
| } |
BenHSmith13
reviewed
Feb 23, 2017
package.json
Outdated
| @@ -29,8 +28,10 @@ | |||
| "react, qti, assessments, quizzes" | |||
| ], | |||
| "dependencies": { | |||
| "del": "^2.2.2" | |||
| "clipboard": "^1.6.0", | |||
There was a problem hiding this comment.
This is in the wrong package.json
BenHSmith13
reviewed
Feb 23, 2017
package.json
Outdated
| @@ -29,8 +28,8 @@ | |||
| "react, qti, assessments, quizzes" | |||
| ], | |||
| "dependencies": { | |||
| "del": "^2.2.2" | |||
| "del": "^2.2.2", | |||
| "react": "^15.4.2" | |||
There was a problem hiding this comment.
dont want react in here either
There was a problem hiding this comment.
how the hell are these things getting in there...
i will fix it
BenHSmith13
approved these changes
Feb 23, 2017
LGTM |
coleshaw
referenced
this pull request
in CLIxIndia-Dev/OpenAssessmentsClient
Feb 27, 2017
* Adds confirmation to delete (#148) * fixes the back button https://www.pivotaltracker.com/story/show/137834749 (#146) * hides stuff if inactive (#147) * Single item or full page (#149) * starting to get offered * if not published take embed code option away * refactor assessOffered cleaner * fix name and killed lambda() * set genusTypeId of single page * PR review changes * changes from PR * Makes feedback work (#151) * show if editable delte (#150) * fixes the refresh in edit assessment (#153) * fixes the refresh in edit assessment * changes languages options * copy stuffs to clipboard (#152) * copy stuffs to clipboard * moved to correct pkg json * delete react * if not titled assessment, doesn't show questions (#156) * checkboxes for only multiple choice for now (#155) * Languages (#154) * copy stuffs to clipboard * moved to correct pkg json * delete react * change languages * updated language codes * Spec branch (#157) * two spec files created * spec files * new spec to add * spec fixes, temp xit of delete functions * note addition * file with qbank server url (#158) * file with qbank server url * refactor for the better * works * better naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code-review checklist
that code is the way it is.