Fix Broken Links [#137061817] #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sting files to work properly Changed xml_parser_spec to check for the proper amount of entries Added entry to xml_parser_spec to check that multiple files in same directory worked as intended
houndci-bot
reviewed
Jan 18, 2017
| MockZip::MockEntry.new("test.dat"), | ||
| ] | ||
|
|
||
| result = Senkyoshi.iterate_files(MockZip.new(mock_entries)) | ||
| assert_equal(result.size, 3) | ||
| assert_equal(result.size, 7)# 4 files + 3 directories = 6 |
There was a problem hiding this comment.
Put a space before an end-of-line comment.
houndci-bot
reviewed
Jan 18, 2017
| MockZip::MockEntry.new("test.dat"), | ||
| ] | ||
|
|
||
| result = Senkyoshi.iterate_files(MockZip.new(mock_entries)) | ||
| assert_equal(result.size, 3) | ||
| assert_equal(result.size, 7)# 4 files + 3 directories = 6 |
There was a problem hiding this comment.
Put a space before an end-of-line comment.
…ed. ("embedded_links.txt" file added)
Added a spec that checks if fix_html gives the right base directory if a file actually exists. ("file1_xid-567_1" is the actual file referenced)
Changed xml_parser_spec comment to math properly
houndci-bot
reviewed
Jan 18, 2017
| CGI.unescapeHTML(file.read) | ||
| end | ||
| @resources.add([@file6]) | ||
| @resources.resources.first.location = "#{Dir.pwd}/spec/fixtures/file1__xid-567_1.txt" |
houndci-bot
reviewed
Jan 18, 2017
| @file5 = Senkyoshi::SenkyoshiFile.new(entry) | ||
|
|
||
| path = "file1__xid-567_1.txt" | ||
| #path = "file1__xid-567_1.txt" |
bfcoder
reviewed
Jan 18, 2017
| @@ -55,6 +56,9 @@ def self.create_canvas_course(resources, zip_name) | |||
| course = CanvasCc::CanvasCC::Models::Course.new | |||
| course.course_code = zip_name | |||
| resources.each do |resource| | |||
| # Skips resources that are files. | |||
There was a problem hiding this comment.
Yes it should, it was changed but not pushed, we are getting a new version to review now
| entry.extract(name) | ||
| name | ||
|
|
||
| begin |
There was a problem hiding this comment.
I'm not a fan of open ended rescues like this. Something unrelated could fail and it will just get swallowed up in the rescue. Is there another way you can check for failures?
There was a problem hiding this comment.
We are going over this now
|
What is the purpose of skipping directories? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes broken links in a few different content types such as assignments and announcements.