Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to upload imscc files #9

Merged
merged 6 commits into from
Dec 12, 2016
Merged

Add ability to upload imscc files #9

merged 6 commits into from
Dec 12, 2016

Conversation

bfcoder
Copy link
Contributor

@bfcoder bfcoder commented Dec 9, 2016

Create a course
Upload content and process
Add specs

Create a course
Upload content and process
Add specs
@bfcoder
Copy link
Contributor Author

bfcoder commented Dec 12, 2016

No, because it isn't one of the models for the canvas structure. CanvasCourse doesn't make sense to me to be in there for that reason. It's not really a model.

@nick-benoit14
Copy link
Contributor

Makes sense. You can go ahead an merge then. Thanks James!

@bfcoder
Copy link
Contributor Author

bfcoder commented Dec 12, 2016

Will you pull the branch down and test it too?

@nick-benoit14
Copy link
Contributor

nick-benoit14 commented Dec 12, 2016

The specs are passing, I do get a 302, which makes rest-client throw an exception, when it is trying to upload the package. I think I may not have something set up quite right. Did you run into that at all?

This is where it is trying to make the post request to https://au.openlmshost.com/files_api

@bfcoder
Copy link
Contributor Author

bfcoder commented Dec 12, 2016

I don't get that exception. Which was weird because canvas said it would happen but it would never happen to me. The docs say it should send back a 302 and I would need to post to the url it came back with in the header as the "location" for it to start processing. But for me it always just start processing... So I need to dig in a little more it looks like.

@bfcoder
Copy link
Contributor Author

bfcoder commented Dec 12, 2016

Or are you talking about in the specs you get that?

@nick-benoit14
Copy link
Contributor

Nope, the specs are fine. It is the post request that is being made by RestClient in upload_content. That is odd though, I was working with it for a while yesterday, and I have been consistently been redirected.

@conradbeach
Copy link

Looks good to me.

@bfcoder bfcoder merged commit 884178e into master Dec 12, 2016
@bfcoder bfcoder deleted the bf-uploader branch December 12, 2016 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants