fix bug that caused logs to not be rendered when --filter-status was …

…empty
atomicptr · Apr 4, 2020 · 40f70fb · 40f70fb
1 parent 3159bdd
commit 40f70fb
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/pkg/filter/filter.go b/pkg/filter/filter.go
@@ -26,6 +26,11 @@ func NewFilter() *Filter {
 
 // IsValid checks if the query is valid for the given value
 func (f *Filter) IsValid(query string, value int64) bool {
+	// empty means no filter was supplied which is always good!
+	if query == "" {
+		return true
+	}
+
 	queries := strings.Split(query, ",")
 
 	result := false

diff --git a/pkg/filter/filter_test.go b/pkg/filter/filter_test.go
@@ -5,6 +5,13 @@ import (
 	"testing"
 )
 
+func TestFilterIsValidEmptyQuery(t *testing.T) {
+	filter := NewFilter()
+	assert.True(t, filter.IsValid("", 200))
+	assert.True(t, filter.IsValid("", 404))
+	assert.True(t, filter.IsValid("", 500))
+}
+
 func TestFilterIsValidSimple(t *testing.T) {
 	filter := NewFilter()
 	assert.True(t, filter.IsValid("200", 200))