Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use per-instance hideOnClick handler #485

Merged
merged 7 commits into from
May 3, 2019
Merged

Conversation

atomiks
Copy link
Owner

@atomiks atomiks commented May 3, 2019

This removes the global click listener in favor of adding one for each instance. This better supports nesting tooltips (e.g. a popover containing buttons with tooltips on them).

  • Needs to be added in both scheduleShow() (triggered by event listeners) and show() (triggered programmatically)
  • Remove checkHideOnClick option from HideAllOptions - this was only for internal use due to the global click listener and was not documented for use
  • Fix in group.ts for supporting this better

@atomiks atomiks merged commit 26201b0 into master May 3, 2019
@atomiks atomiks deleted the per-instance-hideOnClick branch May 3, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant