Modify trigger: 'mouseenter click' behaviour. #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When both triggers, use mouseenter behaviour until reference element click. - On click, show the tippy, no longer hide on mouseleave. - Respect all pre-existing hideOnClick behaviour (true, false, 'toggle'). - Only toggle the tippy on clicking the reference element when hideOnClick='toggle'.
mattsbennett
changed the title
|
Thanks for the PR! Sorry for the delay, I will try and check this tonight. |
|
This is almost good, just
|
|
Ah, right - thank you for the feedback! I'll get back to this ASAP (probably the weekend). |
…d toggle the tippy). - Also, add an assertion to test that the tippy does not hide onmouseleave when the mouseenter and click triggers are specified, and the tippy has been shown via click.
|
Alright, I've addressed the |
|
Edit: nvm it works! The changes didn't get pulled in properly. |
atomiks
reviewed
Dec 27, 2019
|
Thanks for the review! I've made that renaming change. |
|
Thanks a lot! |
|
You bet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation proposal for the changes required for the behaviour change proposed at #649. Currently, the
mouseenterbehaviour always overrides theclickbehaviour. At a high-level, the behaviour change here amounts to respecting themouseenterbehaviour only until the reference element is clicked. Then, the existing click behaviour is respected, until the tippy is hidden (e.g. as perhideOnClick=true||'toggle'). Once hidden again, the existingmouseenterbehaviour is respected once more.Lower-level description:
triggers are specified, respect existing mouseenter behaviour until reference element is clicked.hideOnClickbehaviour (true, false, 'toggle').Only toggle the tippy on clicking the reference element when hideOnClick='toggle' (currently the tippy is always toggled on click (unlessThis conflicts with the preceding point, hence removed (see discussion below).hideOnClickis set tofalse).