Skip to content
This repository has been archived by the owner on Mar 19, 2019. It is now read-only.

findFile doesn't work with leading / #523

Closed
johnsonr opened this issue Apr 17, 2017 · 5 comments
Closed

findFile doesn't work with leading / #523

johnsonr opened this issue Apr 17, 2017 · 5 comments
Labels

Comments

@johnsonr
Copy link
Contributor

ProjectMutableView.findFile can fail to find files if the path given begins with /. A path beginning with / should be treated like a path without an initial /, so the file should be found in both cases.

@ddgenome
Copy link
Contributor

We should probably also be more explicit about this in our docs. Can the ScalaDoc for the function be updated to be more clear as part of this?

@kipz kipz added the bug label Apr 19, 2017
@alankstewart
Copy link
Contributor

@johnsonr I can only see findFile on the currentBackingObject in ProjectMutableView. If so, then this is an issue in ArtifactContainer.findFile in artifact-source

@johnsonr
Copy link
Contributor Author

This seems likely. So an issue should be raised there

@jessitron
Copy link
Contributor

Can we wrap it in ProjectMutableView and strip a leading slash?

kipz added a commit that referenced this issue Apr 24, 2017
kipz added a commit to atomist-attic/artifact-source that referenced this issue Apr 24, 2017
kipz added a commit to atomist-attic/artifact-source that referenced this issue Apr 24, 2017
@kipz kipz reopened this Apr 25, 2017
@kipz
Copy link
Contributor

kipz commented Apr 25, 2017

Let's close once we have pulled in the fixed version of artifact-source.

We could do that on branch containing failing test: https://github.com/atomist/rug/compare/issue-523

alankstewart pushed a commit to atomist-attic/artifact-source that referenced this issue Apr 25, 2017
alankstewart pushed a commit to atomist-attic/artifact-source that referenced this issue Apr 25, 2017
@alankstewart alankstewart reopened this Apr 25, 2017
johnsonr added a commit that referenced this issue Apr 25, 2017
project.findFile fixed to work with paths starting / #523
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants