Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial Gitlab support #399

Merged
merged 21 commits into from
Nov 19, 2018
Merged

Add initial Gitlab support #399

merged 21 commits into from
Nov 19, 2018

Conversation

lievendoclo
Copy link
Contributor

No description provided.

@ddgenome
Copy link
Contributor

ddgenome commented Nov 8, 2018

The name of this PR doesn't seem quite right.

@lievendoclo lievendoclo changed the title TSLint Add initial Gitlab support Nov 8, 2018
@cdupuis
Copy link
Member

cdupuis commented Nov 9, 2018

We will merge that after the 1.0 release.

@lievendoclo lievendoclo added the auto-merge:on-approve Auto-merge on review approvals label Nov 13, 2018
cdupuis
cdupuis reviewed Nov 13, 2018
View reviewed changes
lib/operations/common/AbstractRemoteRepoRef.ts Outdated Show resolved Hide resolved
lib/operations/common/GitlabRepoRef.ts Outdated Show resolved Hide resolved
lib/operations/common/GitlabRepoRef.ts Outdated Show resolved Hide resolved
lib/operations/common/GitlabRepoRef.ts Outdated Show resolved Hide resolved
lib/operations/common/GitlabRepoRef.ts Outdated Show resolved Hide resolved
lib/operations/common/RepoId.ts Outdated Show resolved Hide resolved
lib/operations/common/gitlabRepoLoader.ts Outdated Show resolved Hide resolved
lib/operations/common/params/GitlabTargetsParams.ts Outdated Show resolved Hide resolved
@cdupuis cdupuis added changelog:added Add this issue or pull request to added changelog section auto-merge-method:squash Auto-merge with squash and merge labels Nov 13, 2018
ddgenome
ddgenome reviewed Nov 14, 2018
View reviewed changes
Copy link
Contributor

@ddgenome ddgenome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work. A few comments.

lib/operations/common/GitlabRepoRef.ts Outdated Show resolved Hide resolved
lib/operations/common/GitlabRepoRef.ts Outdated Show resolved Hide resolved
lib/operations/common/GitlabRepoRef.ts Show resolved Hide resolved
lib/operations/common/GitlabRepoRef.ts Outdated Show resolved Hide resolved
lib/operations/common/params/GitlabTargetsParams.ts Outdated Show resolved Hide resolved
lib/operations/generate/GitlabRepoCreationParameters.ts Show resolved Hide resolved
lib/operations/common/GitlabRepoRef.ts Show resolved Hide resolved
@cdupuis
Copy link
Member

cdupuis commented Nov 16, 2018 •
edited
Loading

What is the state of this? We need this PR in master some time Monday. Any chance you could address the review comments @lievendoclo?

@lievendoclo
Copy link
Contributor Author

Comments processed

ddgenome
ddgenome approved these changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@ddgenome ddgenome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@atomist-bot atomist-bot merged commit 322baae into master Nov 19, 2018
@atomist-bot
Copy link
Contributor

Pull request auto merged by Atomist.

[atomist:generated] [auto-merge:on-approve]

@atomist-bot atomist-bot deleted the gitlab-support branch November 19, 2018 19:20
atomist-bot added a commit that referenced this pull request Nov 19, 2018
@atomist-bot
Changelog: #399 to added
9776285 
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddgenome ddgenome ddgenome approved these changes

@cdupuis cdupuis cdupuis approved these changes

Assignees
No one assigned
Labels
auto-merge:on-approve Auto-merge on review approvals auto-merge-method:squash Auto-merge with squash and merge changelog:added Add this issue or pull request to added changelog section
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lievendoclo @ddgenome @cdupuis @atomist-bot