New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract creation of HTTP and WS clients for registration to proper factories #409

Merged
merged 2 commits into from Nov 29, 2018

Conversation

Projects
None yet
3 participants
@cdupuis
Copy link
Contributor

cdupuis commented Nov 29, 2018

With this change, HTTP and WS client can be configured correctly to work
in all sorts of network situations, like tunnelling proxies.

Extract creation of HTTP and WS clients to proper factories
With this change, HTTP and WS client can be configured correctly to work
in all sorts of network situations, like tunnelling proxies.

@cdupuis cdupuis requested a review from ddgenome Nov 29, 2018

@cdupuis cdupuis changed the title Extract creation of HTTP and WS clients to proper factories Extract creation of HTTP and WS clients for registration to proper factories Nov 29, 2018

@ddgenome
Copy link
Member

ddgenome left a comment

LGASONAICYWTATFFTM (Looks good. All suggestions optional. Not approving in case you want to address them. Feel free to merge.)

import * as parseUtils from "./lib/project/util/parseUtils";
import * as projectUtils from "./lib/project/util/projectUtils";
import * as secured from "./lib/secured";
import * as astUtils from "./lib/tree/ast/astUtils";

This comment has been minimized.

@ddgenome

ddgenome Nov 29, 2018

Member

Why move all these? And if you are going to break the alphabetical order, why not put them all at the top or bottom?

method: HttpMethod.Post,
headers: { Authorization: authorization },
options: {
timeout: configuration.ws.timeout || 10000,

This comment has been minimized.

@ddgenome

ddgenome Nov 29, 2018

Member

Shouldn't this default be provided by the configuration defaults?

const retryOptions: WrapOptions = {
...DefaultRetryOptions,
...DefaultRetryOptions as WrapOptions,
...opts,
};
logger.log("silly", `${description} with retry options '%j'`, retryOptions);

This comment has been minimized.

@ddgenome

ddgenome Nov 29, 2018

Member

Should this be inside a opts.log conditional?

@atomist-bot atomist-bot merged commit 38153b5 into master Nov 29, 2018

2 checks passed

license/cla Contributor License Agreement is signed.
Details
sdm/atomist/atomist-sdm Atomist Software Delivery Machine goals: all succeeded
Details
@atomist-bot

This comment has been minimized.

Copy link
Contributor

atomist-bot commented Nov 29, 2018

Pull request auto merged by Atomist.

  • 1 approved review by @ddgenome
  • 2 successful checks

[atomist:generated] [auto-merge:on-approve]

@atomist-bot atomist-bot deleted the http-client-config branch Nov 29, 2018

atomist-bot added a commit that referenced this pull request Nov 29, 2018

Changelog: #409 to changed
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment