Extract creation of HTTP and WS clients for registration to proper factories #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, HTTP and WS client can be configured correctly to work in all sorts of network situations, like tunnelling proxies.
cdupuis
added
changelog:changed
cdupuis
changed the title
ddgenome
reviewed
Nov 29, 2018
| import * as parseUtils from "./lib/project/util/parseUtils"; | ||
| import * as projectUtils from "./lib/project/util/projectUtils"; | ||
| import * as secured from "./lib/secured"; | ||
| import * as astUtils from "./lib/tree/ast/astUtils"; |
There was a problem hiding this comment.
Why move all these? And if you are going to break the alphabetical order, why not put them all at the top or bottom?
| method: HttpMethod.Post, | ||
| headers: { Authorization: authorization }, | ||
| options: { | ||
| timeout: configuration.ws.timeout || 10000, |
There was a problem hiding this comment.
Shouldn't this default be provided by the configuration defaults?
lib/util/retry.ts
Outdated
| const retryOptions: WrapOptions = { | ||
| ...DefaultRetryOptions, | ||
| ...DefaultRetryOptions as WrapOptions, | ||
| ...opts, | ||
| }; | ||
| logger.log("silly", `${description} with retry options '%j'`, retryOptions); |
There was a problem hiding this comment.
Should this be inside a opts.log conditional?
ddgenome
approved these changes
Nov 29, 2018
|
Pull request auto merged by Atomist.
[atomist:generated] [auto-merge:on-approve] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, HTTP and WS client can be configured correctly to work
in all sorts of network situations, like tunnelling proxies.