Make parameters async

atomist · Aug 18, 2020 · a5d885b · a5d885b
1 parent 161b7dd
commit a5d885b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 13 deletions.
diff --git a/lib/pack/universal-generator/generator.ts b/lib/pack/universal-generator/generator.ts
@@ -100,17 +100,15 @@ async function enhanceWithSpecificParameters<P>(
         for (const universalTransform of universalTransforms) {
                 let params: ParametersObject<any>;
                 if (typeof universalTransform.parameters === "function") {
-                  const paramsValues: any = await ctx.promptFor<P>(
-                    unsatisfiedParameters,
-                  );
-                  params = universalTransform.parameters(paramsValues);
+                        const paramsValues: any = await ctx.promptFor<P>(unsatisfiedParameters);
+                        params = await universalTransform.parameters(paramsValues);
                 } else {
-                  params = universalTransform.parameters;
+                        params = universalTransform.parameters;
                 }
                 _.forEach(params, (v, k) => {
-                  if (ctx.parameters[k] === undefined) {
-                    unsatisfiedParameters[k] = v;
-                  }
+                        if (ctx.parameters[k] === undefined) {
+                                unsatisfiedParameters[k] = v;
+                        }
                 });
         }
 

diff --git a/lib/pack/universal-generator/generatorSupport.ts b/lib/pack/universal-generator/generatorSupport.ts
@@ -22,7 +22,6 @@ import {
   metadata,
   ParametersObject,
 } from "@atomist/sdm";
-import * as _ from "lodash";
 import { toArray } from "../../util/misc/array";
 import { universalGenerator } from "./generator";
 
@@ -35,7 +34,7 @@ export interface UniversalTransform<PARAMS = any> {
     /** CodeTransforms to execute */
     transforms: CodeTransform<PARAMS> | Array<CodeTransform<PARAMS>>;
     /** Additional parameters the CodeTransforms need */
-    parameters?: ((params: any) => ParametersObject<PARAMS>) | ParametersObject<PARAMS>;
+    parameters?: ((params: any) => Promise<ParametersObject<PARAMS>>) | ParametersObject<PARAMS>;
 }
 
 /**

diff --git a/test/pack/universal-generator/universalGenerator.test.ts b/test/pack/universal-generator/universalGenerator.test.ts
@@ -17,7 +17,7 @@
 import { GitHubRepoRef } from "@atomist/automation-client/lib/operations/common/GitHubRepoRef";
 import { GeneratorRegistration } from "@atomist/sdm";
 import * as assert from "assert";
-import { UniversalTransform } from "../../../lib/pack/universal-generator/generatorSupport";
+import { UniversalTransform } from "../../..";
 import {
   AssertGeneratorResult,
   assertUniversalGenerator,
@@ -46,13 +46,13 @@ const Trans1UniversalTransform: UniversalTransform<{ firstName: string }> = {
 };
 
 const Trans2UniversalTransform: UniversalTransform<{ middleName: string } | {}> = {
-    parameters: params => {
+    parameters: async params => {
         if (params.firstName === "Mickey") {
             return {
                 middleName: {
                     required: true,
                 },
-            }
+            };
         } else {
             return {};
         }