Always exit with 0

atomist · May 30, 2019 · e5dfdd2 · e5dfdd2
1 parent b5d6c1a
commit e5dfdd2
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/lib/handlers/events/delivery/goals/GoalAutomationEventListener.ts b/lib/handlers/events/delivery/goals/GoalAutomationEventListener.ts
@@ -96,7 +96,10 @@ export class GoalAutomationEventListener extends AutomationEventListenerSupport
                 safeExit(0);
             } catch (e) {
                 logger.error(`Processing goal failed: ${e.message}`);
-                safeExit(1);
+                // We always have to exit with 0 here as otherwise k8s will launch a new instance
+                // FulfillGoalOnRequested throws an error in case of a failing goal
+                // ^ TODO CD look at if that makes any sense or can be changed
+                safeExit(0);
             }
         }
     }