-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify arguments and reintroduce aggregation mode #2
Conversation
I think at least for Also I guess Maybe in general at the start of the script in eval mode, |
Ok, then we need to pass Of course the model path needs to be specific to the evaluation, otherwise, how should we know where the model is stored? |
yes, of course you need to pass the modelpath when calling eval, but the path itself should still be the same as when the model was trained. And I think the modelpath and maybe flags like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
Resolves #1: