Move faraday_middleware-aws-sigv4 to major v0.3.0 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmo0920
approved these changes
Dec 18, 2019
|
@atomita Could you release the new version with this change? |
|
@Evan-S |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is working fine with v0.3.0. Without it, the dependency chain is broken and requires a manual fix on each install.
I think this is what is happening:
fluent-plugin-aws-elasticsearch-service -> fluent-plugin-elasticsearch -> elasticsearch-transport -> elasticsearch-transport (requres faraday (>= 0)) -> faraday (some version higher than 0.15)
Then the faraday_middleware-aws-sigv4 version installed by this project (>= 0.2.4, < 0.3.0) is expecting a faraday below v0.15 resulting in the error in this issue: #59
For every image I'm using this project in, I'm having to run a manual update
gem update faraday_middleware-aws-sigv4The only difference between faraday_middleware-aws-sigv4 v0.2.5 and v0.3.0 is added support for faraday >= 0.15. So, there are no compatibility issues.