Skip to content

Commit

Permalink
Add CONSENSUS node type and separate primary-backup partitions from c…
Browse files Browse the repository at this point in the history 
…onsensus nodes.
  • Loading branch information
@kuujo
kuujo committed Mar 28, 2018
1 parent f9e41bd commit 994b4d3
Show file tree
Hide file tree
Showing 16 changed files with 203 additions and 134 deletions.
0 ...ava/io/atomix/core/BootstrapElection.java → agent/logs/atomix.log
View file
File renamed without changes.
67 changes: 29 additions & 38 deletions agent/src/main/java/io/atomix/agent/AtomixAgent.java
View file
Expand Up @@ -23,7 +23,6 @@
import io.atomix.rest.ManagedRestService;
import io.atomix.rest.RestService;
import net.sourceforge.argparse4j.ArgumentParsers;
import net.sourceforge.argparse4j.impl.action.StoreTrueArgumentAction;
import net.sourceforge.argparse4j.inf.Argument;
import net.sourceforge.argparse4j.inf.ArgumentParser;
import net.sourceforge.argparse4j.inf.ArgumentParserException;
Expand All @@ -45,45 +44,38 @@ public class AtomixAgent {
private static final Logger LOGGER = LoggerFactory.getLogger(AtomixAgent.class);

public static void main(String[] args) throws Exception {
ArgumentType<Node> nodeType = new ArgumentType<Node>() {
@Override
public Node convert(ArgumentParser argumentParser, Argument argument, String value) throws ArgumentParserException {
String[] address = parseAddress(value);
return Node.builder(parseNodeId(address))
.withType(Node.Type.DATA)
.withEndpoint(parseEndpoint(address))
.build();
}
ArgumentType<Node> nodeArgumentType = (ArgumentParser argumentParser, Argument argument, String value) -> {
String[] address = parseAddress(value);
return Node.builder(parseNodeId(address))
.withType(Node.Type.CORE)
.withEndpoint(parseEndpoint(address))
.build();
};

ArgumentType<File> fileType = new ArgumentType<File>() {
@Override
public File convert(ArgumentParser argumentParser, Argument argument, String value) throws ArgumentParserException {
return new File(value);
}
};
ArgumentType<Node.Type> typeArgumentType = (ArgumentParser argumentParser, Argument argument, String value) -> Node.Type.valueOf(value.toUpperCase());
ArgumentType<File> fileArgumentType = (ArgumentParser argumentParser, Argument argument, String value) -> new File(value);

ArgumentParser parser = ArgumentParsers.newArgumentParser("AtomixServer")
.defaultHelp(true)
.description("Atomix server");
parser.addArgument("node")
.type(nodeType)
.type(nodeArgumentType)
.nargs("?")
.metavar("NAME:HOST:PORT")
.setDefault(Node.builder("local")
.withType(Node.Type.DATA)
.withType(Node.Type.CORE)
.withEndpoint(new Endpoint(InetAddress.getByName("127.0.0.1"), NettyMessagingService.DEFAULT_PORT))
.build())
.help("The local node info");
parser.addArgument("--client", "-c")
.action(new StoreTrueArgumentAction())
.help("Indicates this is a client node");
parser.addArgument("--server", "-s")
.action(new StoreTrueArgumentAction())
.help("Indicates that this is a server node");
parser.addArgument("--type", "-t")
.type(typeArgumentType)
.metavar("TYPE")
.choices("core", "data", "client")
.setDefault(Node.Type.CORE)
.help("Indicates the local node type");
parser.addArgument("--bootstrap", "-b")
.nargs("*")
.type(nodeType)
.type(nodeArgumentType)
.metavar("NAME:HOST:PORT")
.required(false)
.help("Bootstraps a new cluster");
Expand All @@ -93,8 +85,8 @@ public File convert(ArgumentParser argumentParser, Argument argument, String val
.required(false)
.setDefault(5678)
.help("An optional HTTP server port");
parser.addArgument("--data-dir", "-d")
.type(fileType)
parser.addArgument("--data-dir", "-dd")
.type(fileArgumentType)
.metavar("FILE")
.required(false)
.setDefault(new File(System.getProperty("user.dir"), "data"))
Expand All @@ -121,12 +113,11 @@ public File convert(ArgumentParser argumentParser, Argument argument, String val
}

Node localNode = namespace.get("node");
if (namespace.getBoolean("client")) {
localNode = Node.builder(localNode.id())
.withType(Node.Type.CLIENT)
.withEndpoint(localNode.endpoint())
.build();
}
Node.Type type = namespace.get("type");
localNode = Node.builder(localNode.id())
.withType(type)
.withEndpoint(localNode.endpoint())
.build();

List<Node> bootstrap = namespace.getList("bootstrap");
if (bootstrap == null) {
Expand All @@ -138,15 +129,15 @@ public File convert(ArgumentParser argumentParser, Argument argument, String val
Integer corePartitions = namespace.getInt("core_partitions");
Integer dataPartitions = namespace.getInt("data_partitions");

LOGGER.info("Node: {}", localNode);
LOGGER.info("Bootstrap: {}", bootstrap);
LOGGER.info("Data: {}", dataDir);
LOGGER.info("node: {}", localNode);
LOGGER.info("bootstrap: {}", bootstrap);
LOGGER.info("data-dir: {}", dataDir);

Atomix atomix = Atomix.builder()
.withLocalNode(localNode)
.withBootstrapNodes(bootstrap)
.withDataDirectory(dataDir)
.withCoordinationPartitions(corePartitions)
.withCorePartitions(corePartitions)
.withDataPartitions(dataPartitions)
.build();

Expand All @@ -165,7 +156,7 @@ public File convert(ArgumentParser argumentParser, Argument argument, String val

rest.start().join();

LOGGER.info("Server listening at {}:{}", localNode.endpoint().host().getHostAddress(), httpPort);
LOGGER.info("HTTP server listening at {}:{}", localNode.endpoint().host().getHostAddress(), httpPort);

synchronized (Atomix.class) {
while (atomix.isRunning()) {
Expand Down
2 changes: 1 addition & 1 deletion cluster/src/main/java/io/atomix/cluster/ClusterMetadata.java
View file
Expand Up @@ -42,7 +42,7 @@ public static Builder builder() {

public ClusterMetadata(Collection<Node> bootstrapNodes) {
this.bootstrapNodes = bootstrapNodes.stream()
.filter(node -> node.type() == Type.DATA)
.filter(node -> node.type() == Type.CORE)
.collect(Collectors.toSet());
}

Expand Down
19 changes: 19 additions & 0 deletions cluster/src/main/java/io/atomix/cluster/Node.java
View file
Expand Up @@ -58,6 +58,20 @@ public static Builder builder(NodeId nodeId) {
return new Builder(checkNotNull(nodeId, "nodeId cannot be null"));
}

/**
* Returns a new core node.
*
* @param nodeId the core node ID
* @param endpoint the core node endpoint
* @return a new core node
*/
public static Node core(NodeId nodeId, Endpoint endpoint) {
return builder(nodeId)
.withType(Type.CORE)
.withEndpoint(endpoint)
.build();
}

/**
* Returns a new data node.
*
Expand Down Expand Up @@ -91,6 +105,11 @@ public static Node client(NodeId nodeId, Endpoint endpoint) {
*/
public enum Type {

/**
* Represents a core node.
*/
CORE,

/**
* Represents a data node.
*/
Expand Down
9 changes: 5 additions & 4 deletions cluster/src/main/java/io/atomix/cluster/impl/DefaultClusterService.java
View file
Expand Up @@ -111,14 +111,14 @@ public Node getLocalNode() {
public Set<Node> getNodes() {
return ImmutableSet.copyOf(nodes.values()
.stream()
.filter(node -> node.type() == Node.Type.DATA || node.getState() == State.ACTIVE)
.filter(node -> node.type() == Node.Type.CORE || node.getState() == State.ACTIVE)
.collect(Collectors.toList()));
}

@Override
public Node getNode(NodeId nodeId) {
Node node = nodes.get(nodeId);
return node != null && (node.type() == Node.Type.DATA || node.getState() == State.ACTIVE) ? node : null;
return node != null && (node.type() == Node.Type.CORE || node.getState() == State.ACTIVE) ? node : null;
}

/**
Expand Down Expand Up @@ -211,9 +211,10 @@ private void deactivateNode(StatefulNode node) {
if (existingNode != null && existingNode.getState() == State.ACTIVE) {
existingNode.setState(State.INACTIVE);
switch (existingNode.type()) {
case DATA:
case CORE:
post(new ClusterEvent(ClusterEvent.Type.NODE_DEACTIVATED, existingNode));
break;
case DATA:
case CLIENT:
post(new ClusterEvent(ClusterEvent.Type.NODE_DEACTIVATED, existingNode));
post(new ClusterEvent(ClusterEvent.Type.NODE_REMOVED, existingNode));
Expand Down Expand Up @@ -243,7 +244,7 @@ private void handleMetadataEvent(ClusterMetadataEvent event) {

// Filter the set of data node IDs from the local node information.
Set<NodeId> dataNodes = nodes.entrySet().stream()
.filter(entry -> entry.getValue().type() == Node.Type.DATA)
.filter(entry -> entry.getValue().type() == Node.Type.CORE)
.map(entry -> entry.getKey())
.collect(Collectors.toSet());

Expand Down
16 changes: 8 additions & 8 deletions cluster/src/test/java/io/atomix/cluster/impl/DefaultClusterMetadataServiceTest.java
View file
Expand Up @@ -57,15 +57,15 @@ public void testSingleNodeBootstrap() throws Exception {

ClusterMetadata clusterMetadata = buildClusterMetadata(1);

Node localNode1 = buildNode(1, Node.Type.DATA);
Node localNode1 = buildNode(1, Node.Type.CORE);
ManagedClusterMetadataService metadataService1 = new DefaultClusterMetadataService(
clusterMetadata, messagingServiceFactory.newMessagingService(localNode1.endpoint()).start().join());

metadataService1.start().join();

assertEquals(1, metadataService1.getMetadata().bootstrapNodes().size());

Node localNode2 = buildNode(2, Node.Type.DATA);
Node localNode2 = buildNode(2, Node.Type.CORE);
ManagedClusterMetadataService metadataService2 = new DefaultClusterMetadataService(
clusterMetadata, messagingServiceFactory.newMessagingService(localNode2.endpoint()).start().join());
metadataService2.start().join();
Expand All @@ -80,15 +80,15 @@ public void testClusterMetadataService() throws Exception {

ClusterMetadata clusterMetadata = buildClusterMetadata(1, 2, 3);

Node localNode1 = buildNode(1, Node.Type.DATA);
Node localNode1 = buildNode(1, Node.Type.CORE);
ManagedClusterMetadataService metadataService1 = new DefaultClusterMetadataService(
clusterMetadata, messagingServiceFactory.newMessagingService(localNode1.endpoint()).start().join());

Node localNode2 = buildNode(2, Node.Type.DATA);
Node localNode2 = buildNode(2, Node.Type.CORE);
ManagedClusterMetadataService metadataService2 = new DefaultClusterMetadataService(
clusterMetadata, messagingServiceFactory.newMessagingService(localNode2.endpoint()).start().join());

Node localNode3 = buildNode(3, Node.Type.DATA);
Node localNode3 = buildNode(3, Node.Type.CORE);
ManagedClusterMetadataService metadataService3 = new DefaultClusterMetadataService(
clusterMetadata, messagingServiceFactory.newMessagingService(localNode3.endpoint()).start().join());

Expand All @@ -102,7 +102,7 @@ public void testClusterMetadataService() throws Exception {
assertEquals(3, metadataService2.getMetadata().bootstrapNodes().size());
assertEquals(3, metadataService3.getMetadata().bootstrapNodes().size());

Node localNode4 = buildNode(4, Node.Type.DATA);
Node localNode4 = buildNode(4, Node.Type.CORE);
ManagedClusterMetadataService metadataService4 = new DefaultClusterMetadataService(
clusterMetadata, messagingServiceFactory.newMessagingService(localNode4.endpoint()).start().join());
metadataService4.start().join();
Expand Down Expand Up @@ -132,7 +132,7 @@ public void testClusterMetadataService() throws Exception {
assertEquals(4, remoteEventListener3.event().subject().bootstrapNodes().size());
assertEquals(4, metadataService3.getMetadata().bootstrapNodes().size());

Node localNode5 = buildNode(5, Node.Type.DATA);
Node localNode5 = buildNode(5, Node.Type.CORE);
ManagedClusterMetadataService metadataService5 = new DefaultClusterMetadataService(
clusterMetadata, messagingServiceFactory.newMessagingService(localNode5.endpoint()).start().join());
metadataService5.start().join();
Expand All @@ -150,7 +150,7 @@ private ClusterMetadata buildClusterMetadata(Integer... bootstrapNodes) {
List<Node> bootstrap = new ArrayList<>();
for (int bootstrapNode : bootstrapNodes) {
bootstrap.add(Node.builder(String.valueOf(bootstrapNode))
.withType(Node.Type.DATA)
.withType(Node.Type.CORE)
.withEndpoint(new Endpoint(localhost, bootstrapNode))
.build());
}
Expand Down

0 comments on commit 994b4d3

Please sign in to comment.