Fix memory leak in Raft member selectors. (#1014)

atomix · Jul 2, 2019 · be6355f · be6355f
1 parent b0d068c
commit be6355f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/...ocols/raft/src/main/java/io/atomix/protocols/raft/session/impl/RaftSessionConnection.java b/...ocols/raft/src/main/java/io/atomix/protocols/raft/session/impl/RaftSessionConnection.java
@@ -306,4 +306,11 @@ protected MemberId next() {
       return currentNode;
     }
   }
+
+  /**
+   * Closes the connection.
+   */
+  public void close() {
+    selector.close();
+  }
 }
diff --git a/protocols/raft/src/main/java/io/atomix/protocols/raft/session/impl/RaftSessionInvoker.java b/protocols/raft/src/main/java/io/atomix/protocols/raft/session/impl/RaftSessionInvoker.java
@@ -216,6 +216,8 @@ public CompletableFuture<Void> close() {
       attempt.fail(new PrimitiveException.ClosedSession("session closed"));
     }
     attempts.clear();
+    sessionConnection.close();
+    leaderConnection.close();
     return CompletableFuture.completedFuture(null);
   }
 

diff --git a/protocols/raft/src/main/java/io/atomix/protocols/raft/session/impl/RaftSessionListener.java b/protocols/raft/src/main/java/io/atomix/protocols/raft/session/impl/RaftSessionListener.java
@@ -140,6 +140,7 @@ private void handlePublish(PublishRequest request) {
    */
   public CompletableFuture<Void> close() {
     protocol.unregisterPublishListener(state.getSessionId());
+    memberSelector.close();
     return CompletableFuture.completedFuture(null);
   }
 }