Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several bugs corrected #1

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Several bugs corrected #1

wants to merge 11 commits into from

Conversation

salva
Copy link
Contributor

@salva salva commented Jan 18, 2012

  • The integer comparison function can overflow resulting on bad order
  • integers where truncated to 32 bits on amd64
  • remove warning caused by int and STRLEN types being different under amd64
  • Benchmarks for Perl native sort and Sort::Key were unfair as they were wrapped inside a sub that introduced considerable overhead.
  • Use isort instead of ikeysort.
  • Remove keysort benchmark as it doesn't make sense.
  • Add benchmark for Sort::Key::Radix::isort
  • Do not crash when an array with holes is passed
  • Sort strings encoded internally as UTF8 correctly
  • Add tests for holes and UTF8 bugs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant