hover show detail feature + minor bug fix #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mawildoer
reviewed
Apr 30, 2024
lishangqiu
force-pushed
the
vscode-extension-hover
branch
from
d6043d0
to
af4557c
Compare
lishangqiu
force-pushed
the
vscode-extension-hover
branch
from
f356434
to
b275454
Compare
|
Alrighty! I think I hit all of your suggestions if you want to take another look. |
|
Thanks @lishangqiu ! I had a little struggle running it via the debugger when I realised that I had broken the debug configuration (which I added a commit to fix) and I fixed another couple of bugs I had previously missed. If you're happy with it, I think we're good to merge |
mawildoer
approved these changes
May 3, 2024
|
Awesome, looks goods to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows details on hover: gives class name + variable values for instances and assigned value for variables. Minor bug fix for when bracket is in a word.