Cloud component db #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nent data has changed
mawildoer
requested changes
Jan 13, 2024
There was a problem hiding this comment.
There's a few comments that got orphaned on Gitlab as we moved over to Github.
Would you be able to address those before we merge this?https://gitlab.atopile.io/atopile/atopile/-/merge_requests/127
mawildoer
reviewed
Jan 13, 2024
mawildoer
reviewed
Jan 13, 2024
mawildoer
reviewed
Jan 15, 2024
mawildoer
approved these changes
Jan 23, 2024
mawildoer
pushed a commit
that referenced
this pull request
Jan 25, 2024
Generic components are now selected using parameters from a database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Components are now fetched from ato component API!
Pretty simply, we just send all the data we have about the component, and the server finds a part using the specified parameters and returns a JSON with the part data.