Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: use pretty = FALSE by default #20

Closed
lexjansen opened this issue Sep 20, 2023 · 1 comment
Closed

Feature Request: use pretty = FALSE by default #20

lexjansen opened this issue Sep 20, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@lexjansen
Copy link

lexjansen commented Sep 20, 2023 •
edited

Feature Idea

Since size has been a concern, it would be good to create Dataset-JSON files that are not 'pretty' formatted.
Current code:
js <- jsonlite::toJSON(
x,
dataframe = "values",
na = "null",
auto_unbox = TRUE,
pretty = pretty)

The default could be pretty = FALSE, with an option to override that behavior.
@lexjansen lexjansen added the enhancement New feature or request label Sep 20, 2023
@mstackhouse
Copy link
Contributor

Thanks for the reminder - I intended to change this.

mstackhouse added a commit that referenced this issue Sep 20, 2023
@mstackhouse
update #20
6632718
@mstackhouse mstackhouse mentioned this issue Sep 20, 2023
Merged
mstackhouse added a commit that referenced this issue Sep 29, 2023
@mstackhouse
Merge pull request #19 from atorus-research/github_issue_3_16
ca1e0ab 
GitHub issue #3,  #16, #17, #18, #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lexjansen @mstackhouse