Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve issue in xml_to_value_spec() when no VLM in define.xml #68

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

kaz462
Copy link
Contributor

@kaz462 kaz462 commented Dec 7, 2022

#64 is resolved in blank_val branch for excel spec.
define_to_metacore() fails when no value level in define.xml, due to this unresolved issue in purrr, temporary workaround added to xml_to_value_spec()

Copy link
Collaborator

@statasaurus statasaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. Thanks for adding it in

@statasaurus statasaurus merged commit c91eb2f into atorus-research:blank_val Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants