Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swarm_labels #24

Merged
merged 1 commit into from
Mar 16, 2017
Merged

Fix swarm_labels #24

merged 1 commit into from
Mar 16, 2017

Conversation

dzimine
Copy link
Contributor

@dzimine dzimine commented Mar 16, 2017

Problem: if swarm_labels not defined at all, it fails on the last step with:

fatal: [node2]: FAILED! => {"failed": true, "msg": "'swarm_labels' is undefined"}

Using when swarm_labels is defined doesn't work with with_items. Let's use defaults instead.

@atosatto
Copy link
Owner

Thank you @dzimine!

@atosatto atosatto merged commit f53224b into atosatto:master Mar 16, 2017
@SergK
Copy link
Contributor

SergK commented Mar 16, 2017

@dzimine thank you for PR, yep it's good to have backward compatibility, afaik this was fixed in ansible/ansible#14383
@atosatto Probably ansible version should be reflected in Requirements section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants