Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reports override correctly when using -ulr/-utr #600

Merged
merged 1 commit into from May 19, 2016

Conversation

jubianchi
Copy link
Member

Before this patch, if we had a configuration file like this one:

<?php

$script->addDefaultReport();

$report = new some\report();
//...
$runner->addReport($telemetry);

And used the -utr or -ulr options, atoum would have dropped the additional report we added through the configuration file and only used the light CLI report or TAP report.

Now, when we do that, atoum will only remove reports which are conflicting with light or TAP report and keep the others.

@mikaelrandy
Copy link
Member

I will release 2.7.0 tomorrow.
I think this bugfix should be included in.
Are you ready to merge ?

@jubianchi
Copy link
Member Author

let's go :)

@jubianchi jubianchi merged commit 020bbcd into atoum:master May 19, 2016
@jubianchi jubianchi deleted the fix-report-override-cli branch May 19, 2016 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants