fix(cli) Fix path to the runner for the help #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
3 similar comments
Hywan
added a commit
that referenced
this pull request
Oct 11, 2017
Explicitely use the current working directory the script directory. This behavior was already present before, but a bug fix (see #770) has revealed this other bug. The script directory must not rely on the script name (which is defined in the `atoum` binary by the `atoum\scripts\runner` constant). The script name points to the binary name most of the time (it is the case right now), but the script directory is the user current working directory, they are not related.
Hywan
added a commit
that referenced
this pull request
Oct 13, 2017
jubianchi
pushed a commit
that referenced
this pull request
Nov 6, 2017
Explicitely use the current working directory the script directory. This behavior was already present before, but a bug fix (see #770) has revealed this other bug. The script directory must not rely on the script name (which is defined in the `atoum` binary by the `atoum\scripts\runner` constant). The script name points to the binary name most of the time (it is the case right now), but the script directory is the user current working directory, they are not related.
jubianchi
pushed a commit
that referenced
this pull request
Nov 6, 2017
Explicitely use the current working directory the script directory. This behavior was already present before, but a bug fix (see #770) has revealed this other bug. The script directory must not rely on the script name (which is defined in the `atoum` binary by the `atoum\scripts\runner` constant). The script name points to the binary name most of the time (it is the case right now), but the script directory is the user current working directory, they are not related.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #761.