Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor UART implementation #329

Closed
5 tasks
twitchyliquid64 opened this issue Nov 23, 2020 · 2 comments · Fixed by #443
Closed
5 tasks

Refactor UART implementation #329

twitchyliquid64 opened this issue Nov 23, 2020 · 2 comments · Fixed by #443
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone
v1.0.0

Comments

@twitchyliquid64
Copy link
Contributor

twitchyliquid64 commented Nov 23, 2020 •
edited

  • Make UART generic over some trait that manages configuration of the baud rate (arithmetic vs fractional)
  • Have methods to enable/disable interrupts & check intflag properly
  • Handle errors properly by reading intflag.ERR + status.*, clearing them, and discarding bytes as appropriate
  • Make UART parameters (stop bits, parity, polarity) configurable
  • Generated documentation needs work
@jessebraham jessebraham added enhancement New feature or request help wanted Extra attention is needed labels Nov 23, 2020
@jessebraham jessebraham added this to the v1.0.0 milestone Nov 24, 2020
@jessebraham jessebraham mentioned this issue Nov 24, 2020
Open
@niclashoyer
Copy link

Does this also include switching the number of data bits? I have a strange requirement where I need 9 data bits, no parity and one stop bit. While the SERCOM on some chips allow such a configuration, it is very uncommon and I feared that it will cause a lot of work down here.

@TDHolmes
Copy link
Contributor

That seems like a reasonable extension of "Make UART parameters configurable" to me

@jbeaurivage jbeaurivage mentioned this issue May 26, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

UART v2 jbeaurivage/atsamd
4 participants
@niclashoyer @jessebraham @twitchyliquid64 @TDHolmes