Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake Warning #52

Closed
cpswan opened this issue Nov 28, 2023 · 1 comment · Fixed by #68
Closed

CMake Warning #52

cpswan opened this issue Nov 28, 2023 · 1 comment · Fixed by #68
Assignees
Labels
bug Something isn't working

Comments

@cpswan
Copy link
Member

cpswan commented Nov 28, 2023

Describe the bug

  The DOWNLOAD_EXTRACT_TIMESTAMP option was not given and policy CMP0135 is
  not set.  The policy's OLD behavior will be used.  When using a URL
  download, the timestamps of extracted files should preferably be that of
  the time of extraction, otherwise code that depends on the extracted
  contents might not be rebuilt if the URL changes.  The OLD behavior
  preserves the timestamps from the archive instead, but this is usually not
  what you want.  Update your project to the NEW behavior or specify the
  DOWNLOAD_EXTRACT_TIMESTAMP option with a value of true to avoid this
  robustness issue.

Steps to reproduce

  1. First I make a PR
  2. Then the CI runs
  3. And then look at the logs for Build Source Tests

Expected behavior

No CMake warnings

@cpswan cpswan added the bug Something isn't working label Nov 28, 2023
@JeremyTubongbanua
Copy link
Member

JeremyTubongbanua commented Dec 11, 2023

Related article(s):
The policy - https://cmake.org/cmake/help/latest/policy/CMP0135.html

Acknowledging the policy sample PR - apache/arrow#37238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants