feat: add useRemoteAtServer to PutRequestOptions and (new) DeleteRequestOptions
#1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdate
request will be sent directly to the remote atServer
- feat: Introduce DeleteRequestOptions
- Add new optional named parameter `deleteRequestOptions` to AtClient.delete
- Add `useRemoteAtServer` to DeleteRequestOptions. When set, the delete
request will be sent directly to the remote atServer
- test: Add tests for the above
- build: update pubspec.yaml and CHANGELOG.md
- docs: Documentation for GetRequestOptions, PutRequestOptions, DeleteRequestOptions
…on-to-force-use-remote-secondary
… to the put and delete methods in AtClient spec
…eliminate this analysis warning which is due to the use of the `unawaited` function which was added in Dart 2.15.0 `warning - lib/src/service/notification_service_impl.dart:401:9 - This API is available since SDK 2.15.0, but constraints '>=2.12.0 <3.0.0' don't guarantee it. Try updating the SDK constraints. - sdk_version_since`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
useRemoteAtServerto PutRequestOptions. When set, the updaterequest will be sent directly to the remote atServer
deleteRequestOptionsto AtClient.deleteuseRemoteAtServerto DeleteRequestOptions. When set, the deleterequest will be sent directly to the remote atServer
- How to verify it
Tests should pass