Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Refactor e2e tests #1028

Merged
merged 3 commits into from
May 14, 2023
Merged

fix: Refactor e2e tests #1028

merged 3 commits into from
May 14, 2023

Conversation

sitaram-kalluri
Copy link
Member

@sitaram-kalluri sitaram-kalluri commented May 11, 2023 •
edited

- What I did

  • Refactor the sharing_key_test and deletion_key_test in E2E tests
  • Refactor the E2E sync logic

- How I did it

  • The result would be inconsistent if the same key name is used in multiple tests. Hence appended a uniqueId for each key in the test to distinguish the keys.
  • In sharing_key_test.dart, use SyncOptions to wait for a specific key to sync before performing the assertations.
  • In E2E Sync Server, refactored the sync logic to have totalWaitTime that waits for 2 minutes and transientWaitTime of 30 seconds.

- How to verify it

  • All the existing tests should pass.

- Description for the changelog

@gkc gkc merged commit 776fda2 into trunk May 14, 2023
6 checks passed
@gkc gkc deleted the refactor_e2e_tests branch May 14, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkc gkc gkc approved these changes

@murali-shris murali-shris Awaiting requested review from murali-shris

@VJag VJag Awaiting requested review from VJag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sitaram-kalluri @gkc