feat: export sync_service interface #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If no one is hard opposed to this change, it does give the developers more flexibility in how they can write their code. |
gkc
approved these changes
May 17, 2023
|
Interesting... I got an email saying that at_client_sdk / end2end_test_14 had failed... |
|
Yeah the e2e tests are flaking; @sitaram-kalluri is working to fix the flakiness I reran one of the e2e tests jobs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1027
- What I did
Exported the sync service interface.
- How I did it
- How to verify it
- Description for the changelog
feat: export sync_service interface