Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add uniqueId to key in bypasscache_test.dart to have unique key … #1038

Merged
merged 1 commit into from
May 18, 2023

Conversation

sitaram-kalluri
Copy link
Member

- What I did

  • Fix the intermittent failure of the by_pass_cache key test.

- How I did it

  • Added a unique Id to the key and the value to ensure a new key is generated for each test. Without the unique key, the same key is being used for each test run and the previous test value is being synced to the client causing intermittent failures
  • Added SyncOptions to ensure assertion waits until the key is synced to the client/server
  • Added TTL of 15 minutes, so that the key will be deleted subsequently
  • Removed the version method that returns the server version which is no longer needed. Checks if the server version is greater than 3.0.29. All test-atSign's are moved to 3.0.31.

- How to verify it

  • The E2E test should pass

@sitaram-kalluri sitaram-kalluri merged commit 7dc3a63 into trunk May 18, 2023
6 checks passed
@sitaram-kalluri sitaram-kalluri deleted the fix_bypasscache_test branch May 18, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants