Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream resume support #214

Draft
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Draft

Stream resume support #214

wants to merge 5 commits into from

Conversation

murali-shris
Copy link
Member

- What I did

Support for stream resume , redesign stream methods and add parsers

- How I did it

  • Deprecated old stream method
  • added new method createStream in spec
  • moved stream logic from at_client_impl to StreamSender and StreamReceiver classes

- How to verify it

  • Run stream sender and stream receiver code in samples
  • To test stream resume, stop the receiver after certain bytes have been received. Call stream resume with start byte = received bytes+1

- Description for the changelog

@gkc
Copy link
Contributor

gkc commented Feb 9, 2023

@murali-shris Is there code here which will be useful when we revisit stream properly? If so, please mark as draft for now, otherwise please close and delete the branch.

@murali-shris murali-shris marked this pull request as draft March 16, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants