feat: encode new line characters in public-key value #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sitaram-kalluri
changed the title
gkc
requested changes
Jul 28, 2022
at_client/lib/src/transformer/request_transformer/put_request_transformer.dart
Outdated
Show resolved
Hide resolved
Fixed the failing tests. |
murali-shris
reviewed
Aug 2, 2022
| if (updateVerbBuilder.value.contains('\n')) { | ||
| updateVerbBuilder.value = | ||
| AtEncoderImpl().encodeData(updateVerbBuilder.value, encodingType); | ||
| updateVerbBuilder.encoding = encodingType.toString().split('.')[1]; |
There was a problem hiding this comment.
please check how to get name from enum in a cleaner way.
we can replace with encodingType.name using extensions
https://stackoverflow.com/questions/29567236/dart-how-to-get-the-name-of-an-enum-as-a-string
There was a problem hiding this comment.
This change is implemented.
murali-shris
reviewed
Aug 2, 2022
|
will approve this PR once server and persistence changes are released |
gkc
reviewed
Aug 8, 2022
Sure Gary, Thank you. |
# Conflicts: # at_client/pubspec.yaml # at_end2end_test/pubspec.yaml # at_functional_test/pubspec.yaml
gkc
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
In
PutRequestTransformercheck if the value contains \n character. If yes, encode the data using base64 and set the encoding attribute to type of encoding used.In
GetResponseTransformer, if the key is public or cached:public: key the data is decoded based on the metadata.encoding which represents the type of encoding used.In sync_service_impl, add encoding attribute in metadata to sync the field between cloud and local secondaries and if metadata.encoding is not null, use updata:json version of regex to sync the data to cloud secondary.
Add unit tests to test the PutRequestTransformer and GetResponseTransformer
- How to verify it
- Description for the changelog