Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add clientConfig to from verb #667

Merged
merged 7 commits into from
Aug 29, 2022
Merged

feat: add clientConfig to from verb #667

merged 7 commits into from
Aug 29, 2022

Conversation

sitaram-kalluri
Copy link
Member

- What I did

  • Send at_client version to server

- How I did it

  • Pass the client version via the clientConfig in AtLookupImpl in the RemoteSecondary.

- How to verify it

- Description for the changelog

gkc
gkc requested changes Aug 24, 2022
View reviewed changes
at_client/lib/src/util/at_client_util.dart Outdated Show resolved Hide resolved
@sitaram-kalluri
Copy link
Member Author

sitaram-kalluri commented Aug 29, 2022 •
edited
Loading

@gkc: Updated the pubspec.yaml with a comment. and changed the e2e test atSign from ce2e4 to ce2e2 because ce2e4 runs on a prod version of at_secondary_server and hence the e2e tests are failing because the changes related to clientConfig are not yet released into Prod. I will a new PR having tests guarded with version checking to support cross version testing.

gkc
gkc previously approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for now

@sitaram-kalluri sitaram-kalluri merged commit 7439636 into trunk Aug 29, 2022
@sitaram-kalluri sitaram-kalluri deleted the add_clientConfig branch September 1, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkc gkc gkc approved these changes

@murali-shris murali-shris murali-shris approved these changes

@VJag VJag Awaiting requested review from VJag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sitaram-kalluri @gkc @murali-shris