fix: biometric storage build issue #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at_client_sdk into fix_biometric_storage
…to fix_biometric_storage
sachins-geekyants
requested review from
cconstab,
murali-shris,
nitesh2599 and
sonle-geekyants
|
Is this the only solution for windows? Seem a kludge to me.. |
| @@ -136,6 +136,13 @@ flutter: | |||
| - .env | |||
| ``` | |||
|
|
|||
| - If your app supports windows platform then add `biometric_storage` in app's dependencies | |||
There was a problem hiding this comment.
we are adding biometric_storage in pubspec..this dependency will be fetched for all platforms..right?
There was a problem hiding this comment.
It throws following exception, on windows platform if does not added under dependencies section.
flutter: #0 MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:294:7)
<asynchronous suspension>
#1 MethodChannelBiometricStorage.getStorage (package:biometric_storage/src/biometric_storage.dart:318:22)
<asynchronous suspension>
#2 KeyChainManager.readAtClientData (package:at_client_mobile/src/keychain_manager.dart:35:21)
<asynchronous suspension>
#3 KeyChainManager.disableUsingSharedStorage (package:at_client_mobile/src/keychain_manager.dart:84:18)
<asynchronous suspension>
#4 KeyChainManager.initialSetup (package:at_client_mobile/src/keychain_manager.dart:78:7)
<asynchronous suspension>
#5 OnboardingService.initialSetup (package:at_onboarding_flutter/services/onboarding_service.dart:87:5)
<asynchronous suspension>
#6 _AtOnboardingStartScreenState._init (package:at_onboarding_flutter/screen/at_onboarding_start_screen.dart:37:5)
<asynchronous suspension>
|
I have raised a ticket in |
…to fix_biometric_storage
murali-shris
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
https://github.com/atsign-foundation/apps/issues/721
https://github.com/atsign-foundation/apps/issues/720
- How I did it
biometric_storageto latest version- How to verify it
at_client_mobilewith this branch.at_client_mobilewith this branch and also updating dependencies as mentioned in readme.- Description for the changelog