feat: initial commit for at_chops uptake #809
Conversation
… in github actions
There was a problem hiding this comment.
Looking good! I've made a few comments; FYI I've also requested a change on the at_chops PR which will have impact here
…t_sdk into uptake_atchops
…/at_client_sdk into uptake_atchops
|
@murali-shris When do you think it will be ready to merge this to trunk? |
Final piece that has to solved is from where to call AtClientImpl._createAtChopsInstance() when atChops instance is not set for an at_client instance. Packages using at_client without at_client_mobile will break because _createAtChopsInstance() needs the encryption and pkam keys set in localSecondary. Alternate approach is have useAtChops=false by default in at_client_preference and tackle one package at a time by setting useAtChops=true when we uptake at_chops for that particular package. |
|
removed at_client_mobile related changes in this PR and moved to a new PR |
|
TODOs before merging this PR
|
…/at_client_sdk into uptake_atchops
done |
| @@ -954,4 +973,27 @@ class AtClientImpl implements AtClient { | |||
| _preference = preference; | |||
| _namespace = namespace; | |||
| } | |||
| } | |||
|
|
|||
| Future<AtChops> _createAtChopsInstance() async { | |||
There was a problem hiding this comment.
Don't think we need this method any more?
There was a problem hiding this comment.
yeah.i will remove this.
- What I did
- How I did it
- How to verify it