fix: sync deleted cached keys #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CurtlyCritchlow
requested review from
sitaram-kalluri,
sachins-geekyants and
sonle-geekyants
XavierChanth
approved these changes
Feb 27, 2023
CurtlyCritchlow
merged commit 2e8de02
into
atsign-foundation:932-sync-deleted-cached-keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
I Modified the
getBatchRequests()method insync_service_impl.dartfile to allow deleted cached keys to sync to cloud secondary.- How I did it
Added
entry.operation != CommitOp.DELETEto the IF statement of thegetBatchRequests()method insync_service_impl.dart- How to verify it
A test should be written for this. This PR goes to a 932-sync-deleted... branch so someone can write a test before merging with trunk.
I verified it by deleting my data on the dude app, uninstalling the app and reinstalling the app and the data remained deleted. Without this fix the deleted data reappeared. You can read about this issue in #932.
- Description for the changelog
Allow deleted cached keys to sync to cloud secondary