Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: NAMESPACE and APIKEY set in the .env file #23

Open
wants to merge 82 commits into
base: trunk
Choose a base branch
from
Open

fix: NAMESPACE and APIKEY set in the .env file #23

wants to merge 82 commits into from

Conversation

CurtlyCritchlow
Copy link
Collaborator

- What I did

- How I did it
- How to verify it

  1. create .env file if it doesn't exist
  2. add NAMESPACE=at_dude in .env file
  3. add API_KEY =
  4. Run the app, you should not see a .env not loaded nor warning set API_KEY before using app in production warning message in the debug console.

- Description for the changelog

NAMESPACE and API_KEY set for the dude app

XavierChanth
XavierChanth requested changes Jan 18, 2023
View reviewed changes
Copy link
Member

@XavierChanth XavierChanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure not to commit .DS_Store files, please add an entry for it in .gitignore

lib/main.dart Outdated
@@ -24,22 +24,25 @@ import 'services/services.dart';
import 'utils/utils.dart';
import 'widgets/widgets.dart';

final AtSignLogger _logger = AtSignLogger(AtEnv.appNamespace);
AtSignLogger _logger = AtSignLogger(AtEnv.appNamespace);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to cause the same issue, since AtEnv.appNamespace is still being called before AtEnv.load(). Instead of passing AtEnv.appNamespace, pass a String.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

lib/main.dart Outdated

Future<void> main() async {
WidgetsFlutterBinding.ensureInitialized();
await AtEnv.load();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already called on line 39, no need to call it again.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@XavierChanth
Copy link
Member

assets/.DS_Store as well please

CurtlyCritchlow and others added 17 commits January 18, 2023 13:56
@CurtlyCritchlow
fix: _logger, uses the string at_dude
96d681a
@CurtlyCritchlow
Merge branch 'trunk' of https://github.com/CurtlyCritchlow/at_dude in…
6e4d164 
…to trunk
@CurtlyCritchlow
Delete .DS_Store
3b3afa9
@CurtlyCritchlow
Merge branch 'trunk' of https://github.com/CurtlyCritchlow/at_dude in…
b6a7041 
…to trunk
@CurtlyCritchlow
fix: stats screen redesign completed
8a9d055
@CurtlyCritchlow
fix: contact screen redesign completed
b46f0d6
@CurtlyCritchlow
feat: settings screen completed except the select a dude persona func…
2ca5c6b 
…tion
@CurtlyCritchlow
fix: settings screen and associated screens redesign implemented.
be9f034
@CurtlyCritchlow
fix: history screen redesign completed
f370773
@CurtlyCritchlow
feat: dude animation added along with changes to dude model
6eb4100
@CurtlyCritchlow
fix: select persona removed from the settings screen
5beb163
@CurtlyCritchlow
fix: dude count shows on history navigation button when the send dude…
99c5de0 
… screen is loaded
@CurtlyCritchlow
feat:dude app redesign completed
b4dcd3e
@CurtlyCritchlow
fix: history changed to notification and blocked screen added
6cea5e9
@CurtlyCritchlow
fix: custom blocked screen no longer reach into the notification bar …
892653d 
…area
@CurtlyCritchlow
splash screen updated
4ee0742
@CurtlyCritchlow
fix:unblocking contacts fix and blocked screen UI updated
114ea43
CurtlyCritchlow and others added 30 commits March 8, 2023 11:15
@CurtlyCritchlow
fix: dude bubble widget color change after dude is played
4d1587a
@CurtlyCritchlow
fix: speaker and trophy emoji is a big as it parents allows
7006b8d
@CurtlyCritchlow
fix: only one dude can be sent at a time and only one select a dude f…
20056c2 
…irst snackbars is displayed
@CurtlyCritchlow
fix: white space removed from left and right edge of send dude and co…
65afcc3 
…ntact screen respectively
@CurtlyCritchlow
fix: contact card on dude screen navigate user to contact screen when…
a2246bb 
… pressed
@CurtlyCritchlow
fix: notification count now shows unheard dudes
7ef55b0
@CurtlyCritchlow
fix:dude replied to now shows a check icon
2b9dd9e
@CurtlyCritchlow
fix:argument are passed to the send dude screen correctly
1bf9601
@CurtlyCritchlow
fix: automatic onboarding and bottom nav bar screen spamming fix
ab2b777
@CurtlyCritchlow
fix: select dude first snackbar message changed to tap ball to select…
952f5ea 
… dude
@CurtlyCritchlow
feat: notification implemented on android
2bfce6b
@sachins-geekyants
fix: search contact exception
a999fdf
@CurtlyCritchlow
.
d983fb8
@sachins-geekyants
fix: replaced contactList with baseContactList
1afd8c7
@CurtlyCritchlow
Merge branch 'fix_notification_reply' into app-ui
737cdfe
@CurtlyCritchlow
fix: reply to notification working
1391eea
@CurtlyCritchlow
fix: null check added before setting dude reply status
a3a557b
@CurtlyCritchlow
fix: notification from new atsign are added to contacts
ff4a897
@CurtlyCritchlow
fix: switching atsign follows new navigation flow
a8b6fd0
@CurtlyCritchlow
fix: send dude when there is no notification follows new navigation flow
fd3acb5
@CurtlyCritchlow
fix: circular cotacts wrapped in fittedbox to fix on a smaller screen
4fc2c40
@CurtlyCritchlow
fix: atsign in the contact list can be replied to
f3f3cb0
@CurtlyCritchlow
fix: notification screen stop flashing contineously
c9dcfb8
@CurtlyCritchlow
fix: new launcher icon added and unecessary call to getDudes removed
2b4512e
@CurtlyCritchlow
chore: build number increased
813f74a
@CurtlyCritchlow
feat: pana workflow added
606ac04
@CurtlyCritchlow
Merge pull request #3 from CurtlyCritchlow/app-ui
e5a483b 
App UI
@CurtlyCritchlow
chore: pane workflow updated with comment
5bfc857
@CurtlyCritchlow
chore: pana score reference to reusable workflow updated"
baa8a59 
"
"
""
@CurtlyCritchlow
Merge pull request #4 from CurtlyCritchlow/app-ui
3b7e156 
chore: pane workflow updated with comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierChanth XavierChanth XavierChanth requested changes

@nickelskevin nickelskevin Awaiting requested review from nickelskevin

@TylerTrott TylerTrott Awaiting requested review from TylerTrott

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set app namespace and api_key
3 participants
@CurtlyCritchlow @XavierChanth @sachins-geekyants