Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix cached: prefix in Scan CLI #64

Merged
merged 1 commit into from
Oct 16, 2022

Conversation

JeremyTubongbanua
Copy link
Member

What I did

Checked for isCached metadata and prepend cached: to the key name if isCached==true

Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkc
Copy link
Contributor

gkc commented Oct 15, 2022

LGTM

@JeremyTubongbanua What's your plan for the scan impl itself?

@JeremyTubongbanua
Copy link
Member Author

LGTM

@JeremyTubongbanua What's your plan for the scan impl itself?

The getAtKeys() method returns a List<AtKey>, I don't think there's much I could do unless I modify the .toString() in AtKey

@gkc
Copy link
Contributor

gkc commented Oct 16, 2022

Yeah it's a bit tricky. Here's the way I think all of this should work: cached should not be a part of the key name. When @bob creates data which they share with @alice, and @alice secondary decides to cache that data (for whatever reason), then I believe there is zero value in prepending 'cached:' to the key name, since the very fact that @bob-owned data is stored on @alice's secondary shows that it is cached.

@nickelskevin what do you think about this? This is relevant given our recent & ongoing conversation about overhauling caching behaviour generally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants