Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix for find secondary #165

Merged
merged 3 commits into from
Apr 26, 2022
Merged

bug fix for find secondary #165

merged 3 commits into from
Apr 26, 2022

Conversation

murali-shris
Copy link
Member

@murali-shris murali-shris commented Apr 26, 2022 •
edited

- What I did

  • decode of data in refactored CacheableSecondaryAddressFinder is missing due to accidental code comment

- How I did it

  • uncommented the code
    - How to verify it
  • update functional tests/end2end test pubspec to use findsecondary_bug branch of at_lookup and run the tests

@murali-shris murali-shris merged commit 120fb3d into trunk Apr 26, 2022
@sitaram-kalluri sitaram-kalluri deleted the findsecondary_bug branch June 28, 2022 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sitaram-kalluri sitaram-kalluri sitaram-kalluri approved these changes

@gkc gkc Awaiting requested review from gkc

@VJag VJag Awaiting requested review from VJag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@murali-shris @sitaram-kalluri